Differential D2656

[Kickoff] Lazy load more
ClosedPublic
Actions

Authored by broulik on Sep 4 2016, 6:50 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:1ff59def8c6d: [Kickoff] Lazy load more
Summary

Neither the apps model nor favorites model is needed initially. Move them to the fullRepresentation so they're only loaded as needed.

Test Plan

Favorites still show, adding/removing ones is persistent across reboots. The context menus of the apps model and krunner results reflect the favorites state correctly.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6428.Sep 4 2016, 6:50 PM
broulik retitled this revision from to [Kickoff] Lazy load more.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2016, 6:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Sep 5 2016, 5:01 AM

Did you test Dashboard?

broulik added a comment.Sep 5 2016, 5:50 AM

Dashboard? This is Kickoff, not Kicker

hein accepted this revision.Sep 5 2016, 6:36 AM
hein edited edge metadata.

Sorry, brain fart :)

This revision is now accepted and ready to land.Sep 5 2016, 6:36 AM
Closed by commit R119:1ff59def8c6d: [Kickoff] Lazy load more (authored by broulik). · Explain WhySep 5 2016, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6438

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...
View Options

applets/kickoff/package/contents/ui/Kickoff.qml

Loading...