I have done the following changes:
- Added a OK button to check answer
- Added level selection for full hours
jjazeix | |
echarruau | |
timotheegiet |
GCompris: Improvements |
I have done the following changes:
No Linters Available |
No Unit Test Coverage |
Buildable 21005 | |
Build 21023: arc lint + arc unit |
I have added all the different configurations as defined for the dataset of clock-game.
I have done the following changes:
@echarruau @jjazeix Please review.
Thanks!
src/activities/clockgame/Clockgame.qml | ||
---|---|---|
458 | it would be better to have the button on the right side else it may override with the clock | |
src/activities/clockgame/clockgame.js | ||
41–42 | it would be easier to do : items.targetH = Math.floor(Math.random() * 12) if(!items.levels[currentLevel].twentyfourHoursFormat) { items.targetH += 12 } | |
89 | you don't need to duplicate all the function. if (((items.currentH === items.targetH) || (items.currentH === (items.targetH - 12))) && items.currentM === items.targetM && items.currentS === items.targetS) { items.bonus.good("gnu") } else { items.bonus.bad("gnu") } |
For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:
...
I think we should use https://doc.qt.io/qt-5/qml-qtqml-date.html to format the time correctly (but it is work for the other task)
I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.
src/activities/clockgame/resource/3/Data.qml | ||
---|---|---|
3 | need to be updated (also in level 5) |
On my side I do not see anything to correct so far. I think next test will be done by real pupils :) Great work!
src/activities/clockgame/resource/1/Data.qml | ||
---|---|---|
25 | Here change to 4 (teaching clock is started around 6 years old). | |
src/activities/clockgame/resource/2/Data.qml | ||
25 | Here change to 4. | |
src/activities/clockgame/resource/4/Data.qml | ||
25 | Here change to 5. | |
src/activities/clockgame/resource/5/Data.qml | ||
25 | Here change to 6. |
Thank you, pushed in https://commits.kde.org/gcompris/730ff4e546edb0227ff5f376ebc1feb77869c91e (I did the change @echarruau mentioned on difficulties)