Add a logging category for the backend
ClosedPublic

Authored by meven on Jan 8 2020, 8:28 PM.

Details

Summary

To get rid of tons of logs like :
using... PackageKit::Transaction(0x55db7f249ab0) "/14940_dbaecdcb"
using... PackageKit::Transaction(0x55db7f33fba0) "/14940_dbaecdcb"
using... PackageKit::Transaction(0x55db7d97b860) "/14941_ecaeeebe"

Test Plan

builds

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 8 2020, 8:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2020, 8:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Jan 8 2020, 8:28 PM
apol accepted this revision.Jan 9 2020, 1:13 AM
This revision is now accepted and ready to land.Jan 9 2020, 1:13 AM
mlaurent requested changes to this revision.Jan 9 2020, 6:14 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
libdiscover/backends/PackageKitBackend/CMakeLists.txt
16

Why adding it ? it's autogenerated so it's added by cmake directly

32

Why you add this file too ? it's autogenerated by ecm_qt_declare_logging_category and added directly

This revision now requires changes to proceed.Jan 9 2020, 6:14 AM
meven updated this revision to Diff 73119.Jan 9 2020, 9:31 AM

Fix CMake( add _SRCS vars)

meven marked 2 inline comments as done.Jan 9 2020, 9:33 AM
meven added inline comments.
libdiscover/backends/PackageKitBackend/CMakeLists.txt
16

The issue was that add_library takes directly a list of cpp directly, but ecm_qt_declare_logging_category needs a list of SRCS to append its generated cpp file.
The cmake file was lacking _SRCS list variable in sum.

meven marked an inline comment as done.Jan 9 2020, 9:33 AM
meven marked an inline comment as done.Jan 9 2020, 9:46 AM
mlaurent accepted this revision.Jan 9 2020, 10:37 AM

Seems ok now for me :) thanks

This revision is now accepted and ready to land.Jan 9 2020, 10:37 AM
This revision was automatically updated to reflect the committed changes.