ModuleView: Hide button when KCModule don't need them
ClosedPublic

Authored by bport on Jan 8 2020, 9:44 AM.

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Jan 8 2020, 9:44 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2020, 9:44 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Jan 8 2020, 9:44 AM
ervin accepted this revision.Jan 8 2020, 10:05 AM
This revision is now accepted and ready to land.Jan 8 2020, 10:05 AM
meven added inline comments.Jan 8 2020, 10:07 AM
core/ModuleView.cpp
398–399

d->mHelp->setVisible(buttons & KCModule::Help ) ?

bport updated this revision to Diff 73043.Jan 8 2020, 10:09 AM

Set visibility for help too

ervin added inline comments.Jan 8 2020, 10:10 AM
core/ModuleView.cpp
398–399

Nope, see my comment on the other patch :-)

ervin accepted this revision.Jan 8 2020, 10:44 AM

Doesn't quite make sense to both hide and disable, but no big deal.

core/ModuleView.cpp
398–399

Alright, I'll contradict myself, the doc claimed the contrary forever.

This revision was automatically updated to reflect the committed changes.