Differential D26516

[Icon Item] Check URL validity and scheme
ClosedPublic
Actions

Authored by broulik on Jan 8 2020, 9:39 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:c7eeee65c990: [Icon Item] Check URL validity and scheme
Summary

Creating a KFileItemList with a KFileItem with a URL that doesn't have a scheme triggers an assert in KFileItemListProperties.
It doesn't really make sense to have anyway.

Test Plan
  • Created an icon item with a desktop file with a URL=foo, no longer quit plasmashell when right clicking.

Instead, the menu is empty now. Open with actions for proper files still work

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 8 2020, 9:39 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 8 2020, 9:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 8 2020, 9:39 AM
mart accepted this revision.Jan 10 2020, 12:25 PM
This revision is now accepted and ready to land.Jan 10 2020, 12:25 PM
Closed by commit R120:c7eeee65c990: [Icon Item] Check URL validity and scheme (authored by broulik). · Explain WhyJan 13 2020, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/icon/iconapplet.cpp (40 lines)

Diff 73393

View Options

applets/icon/iconapplet.cpp

Loading...