[Panel Shadows] Port to KWindowSystem shadows API
ClosedPublic

Authored by zzag on Jan 7 2020, 7:18 PM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 7 2020, 7:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 7 2020, 7:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jan 7 2020, 7:18 PM
zzag retitled this revision from [WIP] [Panel Shadows] Port to KWindowSystem shadows API to [Panel Shadows] Port to KWindowSystem shadows API.Jan 7 2020, 7:47 PM
zzag edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jan 22 2020, 10:46 AM
davidedmundson added a subscriber: davidedmundson.

I love red!

shell/panelshadows.cpp
184

you can pass a parent here, then we don't need to clean up in the destructor

This revision is now accepted and ready to land.Jan 22 2020, 10:46 AM
zzag added inline comments.Jan 22 2020, 10:56 AM
shell/panelshadows.cpp
184

Do you mean shadow = new KWindowShadow(this);?

zzag updated this revision to Diff 74097.Jan 22 2020, 11:07 AM

Pass PanelShadows to constructor

This revision was automatically updated to reflect the committed changes.