Clean reference to log_kdepassword
ClosedPublic

Authored by meven on Jan 7 2020, 3:35 PM.

Diff Detail

Repository
R355 KDebugSettings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 7 2020, 3:35 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 7 2020, 3:35 PM
meven requested review of this revision.Jan 7 2020, 3:35 PM
mlaurent requested changes to this revision.Jan 7 2020, 3:52 PM
mlaurent added inline comments.
data/kde.renamecategories
1 ↗(On Diff #72989)

I keep it for developers. So they know how to create .renamecategories file.

Without it dev will not how to create a renamecategories file

data/kdebugsettings.categories
1 ↗(On Diff #72989)

why ? "DEFAULT_SEVERITY [DEBUG]" :)

"ecm_qt_declare_logging_category(kdebugsettings_debug_SRCS HEADER kdebugsettings_debug.h IDENTIFIER KDEBUGSETTINGS_LOG CATEGORY_NAME log_kdebugsettings)"
we don't force it.
If you force it in .categories file if a day we change default settings in ecm_qt_declare_logging_category we will change all categories file.
So by default kdebugsettings loads correct DEFAULT_SEVERITY in interface.

This revision now requires changes to proceed.Jan 7 2020, 3:52 PM
meven retitled this revision from Remove unused file kde.renamecategories and clean reference to log_kdepassword to Clean reference to log_kdepassword.Jan 8 2020, 7:27 PM
meven updated this revision to Diff 73091.Jan 8 2020, 7:28 PM

Remove unneeded changes

mlaurent accepted this revision.Jan 9 2020, 5:56 AM
This revision is now accepted and ready to land.Jan 9 2020, 5:56 AM
This revision was automatically updated to reflect the committed changes.