Prevents warning when launching kdebugsettings such as:
log_kdebugsettings: In this file: "/home/meven/kde/usr/etc/xdg/kio.categories" this line "kf5.kio.cookiejar kcookiejar (KIO)" still use old format. We need to port it
Details
Details
- Reviewers
mlaurent - Group Reviewers
Frameworks
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20754 Build 20772: arc lint + arc unit
Comment Actions
But you're wrong "log_kdebugsettings: In this file: "/home/meven/kde/usr/etc/xdg/kio.categories" this line "kf5.kio.cookiejar kcookiejar (KIO)" still use old format. We need to port it" it not for missing DEFAULT_SEVERITY argument it's just that kio.categories doesnt use new format.
but it seems that it's an old version as here I don't see this warning for kio.categories.
And you add DEFAULT_SEVERITY [WARNING] but ecm_qt_declare_logging_category doesn"t use WARNING as default argument for example:
"ecm_qt_declare_logging_category(kio_trash_PART_DEBUG_SRCS HEADER kiotrashdebug.h IDENTIFIER KIO_TRASH CATEGORY_NAME kf5.kio.trash)"
so this patch is not correct for sure.
| kio.categories | ||
|---|---|---|
| 17 | It's not correct when you paste DEFAULT_SEVERITY [WARNING] => you add "I" from identifier | |
Comment Actions
Thanks @mlaurent I just have old files installed on my system and got confused, I thought DEFAULT_SEVERITY was mandatory.