Use qmlRegisterAnonymousType
ClosedPublic

Authored by tcanabrava on Jan 7 2020, 11:12 AM.

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Jan 7 2020, 11:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 7 2020, 11:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jan 7 2020, 11:12 AM
broulik requested changes to this revision.EditedJan 7 2020, 11:13 AM
broulik added a subscriber: broulik.

needs a qt version ifdef

Also, I'm actually not sure you can register something into org.kde.milou namspace outside the plugin. The import is sealed after registerTypes is called, so perhaps QMimeData needs to be registered there instead of the class constructor.

This revision now requires changes to proceed.Jan 7 2020, 11:13 AM
meven added a subscriber: meven.Jan 8 2020, 2:04 PM
meven added inline comments.
lib/draghelper.cpp
31–32

indentation

tcanabrava updated this revision to Diff 73276.Jan 11 2020, 3:17 PM
  • Move typeRegistration to the Plugin instanciation
broulik accepted this revision.Jan 11 2020, 3:19 PM

Thanks

This revision is now accepted and ready to land.Jan 11 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.