Differential D26487

[Kuit] Revert changes in parseUiMarker()
ClosedPublic
Actions

Authored by ahmadsamir on Jan 7 2020, 9:32 AM.

Details

Reviewers
ilic
dfaure
Group Reviewers
Frameworks
Commits
R249:fff18126b973: [Kuit] Revert changes in parseUiMarker()
Summary

This commit partially reverts a9f4cbdda790c3962:

  • A simple regex is used to find the first whitespace
  • Use QString::indexOf() to search for ':' and '/'

This is faster than using a complex regex. For more details see the
discussion in D26366.

Test Plan

make && ctest

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Jan 7 2020, 9:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 7 2020, 9:32 AM
ahmadsamir requested review of this revision.Jan 7 2020, 9:32 AM
dfaure accepted this revision.Jan 11 2020, 9:14 AM
This revision is now accepted and ready to land.Jan 11 2020, 9:14 AM
Closed by commit R249:fff18126b973: [Kuit] Revert changes in parseUiMarker() (authored by ahmadsamir). · Explain WhyJan 11 2020, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kuitmarkup.cpp (30 lines)

Diff 73251

View Options

src/kuitmarkup.cpp

Loading...