feat(kcm): control scale
ClosedPublic

Authored by romangg on Jan 7 2020, 12:19 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R104:a5c4e9906322: feat(kcm): control scale
Summary

Some backends might not transmit scale information. For these save the scale
value in the control file on change.

Loading it from there is unproblematic in all three cases:

  • No scale value in file. Then falls back to libkscreen's value (default = 1).
  • Scale values are the same, that means backend transmits scale.
  • Backend does not transmit and scale is different, then prefer control file.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Jan 7 2020, 12:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 7 2020, 12:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Jan 7 2020, 12:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2020, 3:10 PM
This revision was automatically updated to reflect the committed changes.

I don't understand where you're going with this.

Can you explain what backend doesn't have a scale that is still worth saving on the output?

On wayland we do have scale transmitted, for X we don't currently support per-output scaling.