[kstyle] Drop Qt 4 style plugin
Needs ReviewPublic

Authored by zzag on Mon, Jan 6, 7:49 PM.

Details

Reviewers
None
Group Reviewers
KWin
Plasma
Maniphest Tasks
T12496: Shadows API in KWindowSystem
Summary

KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand,
we need to use KWindowSystem to make QWidget-based internal clients in
KWin cast drop-shadows.

Another problem with the Qt 4 style plugin is that some distributions
have already dropped Qt 4, so one has to build it first in order to
verify that his or her change works with Qt 4.

Given maintenance burden and the fact that Qt 6 is around the corner,
this change drops the Qt 4 style plugin.

Diff Detail

Repository
R31 Breeze
Branch
port-to-shadows-api
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21035
Build 21053: arc lint + arc unit
zzag created this revision.Mon, Jan 6, 7:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Jan 6, 7:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Mon, Jan 6, 7:49 PM
mart added a subscriber: mart.EditedTue, Jan 7, 9:31 AM

+1,
not an huge loss for me, qt4 clients are becoming very rare anyways

I don't think this is the right approach as it regresses the Qt4 style.
We can achieve the same thing by having packagers just continue to build an existing old tarball. They keep the shadows, and we can fix Breeze not just for this but other Qt5 porting.

I've emailed plasma and kde-distro-packagers for feedback.

zzag added a comment.EditedTue, Jan 7, 10:11 AM

Do you suggest to move qt 4 style plugin to its own repo? I'm not sure that I follow you.

EDIT: never mind, I just saw your email.

zzag planned changes to this revision.Sun, Jan 12, 6:59 PM
zzag updated this revision to Diff 73387.Mon, Jan 13, 10:37 AM

Drop Qt 4 style plugin

zzag retitled this revision from [kstyle] Remove shadows in Qt 4 style plugin to [kstyle] Drop Qt 4 style plugin.Mon, Jan 13, 10:56 AM
zzag edited the summary of this revision. (Show Details)