[FileMetaDataProvider] support symlinks with a new "Link to" item
ClosedPublic

Authored by pdabrowski on Jan 6 2020, 2:35 PM.

Details

Summary

Add information about symbolic links to FileMetaDataProvider
with a new "Link to" ("kfileitem#linkDest") item

Dolphin tool-tip before:

Dolphin tool-tip after:

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pdabrowski created this revision.Jan 6 2020, 2:35 PM
Restricted Application added a project: Baloo. · View Herald TranscriptJan 6 2020, 2:35 PM
pdabrowski requested review of this revision.Jan 6 2020, 2:35 PM
pdabrowski edited the summary of this revision. (Show Details)Jan 6 2020, 2:38 PM
ngraham accepted this revision.Jan 6 2020, 3:29 PM

Very nice.

This revision is now accepted and ready to land.Jan 6 2020, 3:29 PM
ngraham added a subscriber: bruns.Jan 6 2020, 3:29 PM

@bruns, are you good with this?

bruns added a comment.Jan 6 2020, 8:25 PM

In general I am fine with this, but we should strive for some consistency here:

  • The detailed view has a "Link Destination" column
  • The status bar has "<Name> (<Type>, Link to <Destination>)

How about only adding the "Link to:"/"Link Destination" to the detailed view, but moving it up in the ordering:

   Type : Folder
Link to : ../../kde
pdabrowski updated this revision to Diff 72997.Jan 7 2020, 4:10 PM
pdabrowski retitled this revision from [FileMetaDataProvider] symlinks: "(link)" suffix in Type, new "Link to" item to [FileMetaDataProvider] support symlinks with a new "Link to" item.
pdabrowski edited the summary of this revision. (Show Details)

How about only adding the "Link to:"/"Link Destination" to the detailed view, but moving it up in the ordering:

Done.

Second thought on the label:
maybe instead of "Link to:" (noun) it should say "Links to:" or "Linked to:" (verb) to better match labels like "Modified:"?

"Link Destination:" is also fine, but imho takes too much space.
Though translations will probably spoil this effort to have a short label anyway.

meven accepted this revision.Jan 7 2020, 4:58 PM
meven added a subscriber: meven.

Second thought on the label:
maybe instead of "Link to:" (noun) it should say "Links to:" or "Linked to:" (verb) to better match labels like "Modified:"?

I would be in favor of keeping "Link to:" (noun form) for consistency with other fields in the widget concerned ("Size:" and not "Weights:" "Note" and not ) and other component (i.e details view column).
We currently have only one exception regarding dates, as "Creation date" is quite longer than "Created" for instance.

bruns accepted this revision.Jan 8 2020, 1:29 AM
This revision was automatically updated to reflect the committed changes.