Differential D26467

KCM runners: fix default button
ClosedPublic
Actions

Authored by bport on Jan 6 2020, 1:31 PM.

Details

Reviewers
ervin
meven
crossi
Group Reviewers
Plasma
Commits
R119:be1eacc05b1f: KCM runners: fix default button
Summary

connect new signal from KPluginSelector to respect default button state

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Jan 6 2020, 1:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2020, 1:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Jan 6 2020, 1:31 PM
ervin accepted this revision.Jan 6 2020, 1:52 PM

Waiting on D26466 to get in of course.

This revision is now accepted and ready to land.Jan 6 2020, 1:52 PM
davidedmundson added a subscriber: davidedmundson.Jan 6 2020, 2:06 PM

We're entering an awkward part of the Plasma release cycle.

Our next beta is in 3 weeks but will depend on the framework that has just been tagged.
Any changes entering master, need to be compilable against 5.66 otherwise they will have to wait until after Plasma/5.18 branches

ervin added a comment.Jan 6 2020, 2:28 PM
In D26467#588812, @davidedmundson wrote:

We're entering an awkward part of the Plasma release cycle.

Our next beta is in 3 weeks but will depend on the framework that has just been tagged.
Any changes entering master, need to be compilable against 5.66 otherwise they will have to wait until after Plasma/5.18 branches

So ifdefs for cases like this one? Note however that we could go through SIGNAL/SLOT macros in that particular case, there'd be a spurious warning on 5.66 though.

bport updated this revision to Diff 72905.Jan 6 2020, 4:08 PM

Check KCMUtils version

ervin accepted this revision.Jan 6 2020, 4:18 PM
Closed by commit R119:be1eacc05b1f: KCM runners: fix default button (authored by bport). · Explain WhyJan 7 2020, 9:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/runners/kcm.cpp (7 lines)

Diff 72953

View Options

kcms/runners/kcm.cpp

Loading...