[windowsystem] Provide a KWindowShadow implementation
ClosedPublic

Authored by zzag on Jan 6 2020, 10:30 AM.

Diff Detail

Repository
R130 Frameworks integration plugin using KWayland
Branch
port-to-shadows-api
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21030
Build 21048: arc lint + arc unit
zzag created this revision.Jan 6 2020, 10:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2020, 10:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jan 6 2020, 10:30 AM
zzag updated this revision to Diff 73350.Jan 12 2020, 6:54 PM

Track Shadow object

zzag updated this revision to Diff 73380.Jan 13 2020, 9:47 AM

Fix a typo

zzag updated this revision to Diff 73381.Jan 13 2020, 9:49 AM

Update.

zzag updated this revision to Diff 73729.Jan 16 2020, 5:59 PM

Adjust to recent changes in KWindowShadow

davidedmundson requested changes to this revision.Jan 21 2020, 11:45 PM
davidedmundson added a subscriber: davidedmundson.

One minor change, otherwise it's all good.

src/windowsystem/windowshadow.cpp
100

Lets avoid this.

Firstly it messes with Qt. We're doing this potentially during platform window initialisation, we're potentially committing before it's set some super important properties that we need set on the first commit.

Secondly, we want it atomic with when the window updates (to a new theme or whatever) anyway.

window->requestUpdate(); would be a compromise, it'll make Qt do a commit at the next available time.

This revision now requires changes to proceed.Jan 21 2020, 11:45 PM
zzag updated this revision to Diff 74057.Jan 22 2020, 12:03 AM

Use QWindow::requestUpdate()

zzag marked an inline comment as done.Jan 22 2020, 12:04 AM
davidedmundson accepted this revision.Jan 22 2020, 12:10 AM
This revision is now accepted and ready to land.Jan 22 2020, 12:10 AM
This revision was automatically updated to reflect the committed changes.