Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Maniphest Tasks
- T12496: Shadows API in KWindowSystem
- Commits
- R130:8b0244949229: [windowsystem] Provide a KWindowShadow implementation
Diff Detail
Diff Detail
- Repository
- R130 Frameworks integration plugin using KWayland
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
One minor change, otherwise it's all good.
src/windowsystem/windowshadow.cpp | ||
---|---|---|
100 | Lets avoid this. Firstly it messes with Qt. We're doing this potentially during platform window initialisation, we're potentially committing before it's set some super important properties that we need set on the first commit. Secondly, we want it atomic with when the window updates (to a new theme or whatever) anyway. window->requestUpdate(); would be a compromise, it'll make Qt do a commit at the next available time. |