Differential D26445

[KRunner KCM] Mark KCM as dirty when plugin configuration changes
ClosedPublic
Actions

Authored by broulik on Jan 5 2020, 8:18 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin configuration changes
Summary

Connect configCommitted to ensure "Apply" gets enabled when you change any of the runner plugin settings.
Also, clean up the other connect.

Test Plan
  • Connecting to dirty insted of markAsDirty so it can go into 5.17
  • Opened KCM, opened dictionary runner settings, changed keyword, "Apply" not got enabled as expected

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 5 2020, 8:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 5 2020, 8:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 5 2020, 8:18 PM
davidedmundson accepted this revision.Jan 5 2020, 9:33 PM
This revision is now accepted and ready to land.Jan 5 2020, 9:33 PM
Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin configuration changes (authored by broulik). · Explain WhyJan 7 2020, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/runners/kcm.cpp (8 lines)

Diff 72957

View Options

kcms/runners/kcm.cpp

Loading...