New icon for KTimeTracker
ClosedPublic

Authored by cblack on Jan 5 2020, 7:18 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:dca95f680776: New icon for KTimeTracker
Summary

This diff adds a new icon for KTimeTracker.

T12305

BUG: 410708

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Jan 5 2020, 7:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 5 2020, 7:18 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cblack requested review of this revision.Jan 5 2020, 7:18 PM
cblack edited the test plan for this revision. (Show Details)Jan 5 2020, 7:19 PM
ndavis added a subscriber: ndavis.EditedJan 5 2020, 8:52 PM

The top part looks a bit too flat and wide. There's also nothing attaching it to the body, so it looks like it's floating.

I don't think Plasma Blue works well as a body color with no outline. This happens when I select the file in dolphin because it blends in with the highlight:

I'd suggest using a different color.

cblack updated this revision to Diff 74286.Jan 24 2020, 12:28 AM

Adjust colour from blue to mahogany

ndavis requested changes to this revision.Jan 24 2020, 1:38 AM
ndavis added a subscriber: hellcp.

I have to agree with what @hellcp said in the VDG chat earlier, the mahogany really does not fit. It draws attention to the wrong places and is confusing.

This revision now requires changes to proceed.Jan 24 2020, 1:38 AM
cblack updated this revision to Diff 74293.Jan 24 2020, 4:37 AM

Use a rich grey instead of a rich mahogany

cblack edited the test plan for this revision. (Show Details)Jan 24 2020, 4:37 AM
ndavis accepted this revision.Feb 7 2020, 11:01 PM

I think I'll just accept this as it is.

This revision is now accepted and ready to land.Feb 7 2020, 11:01 PM
This revision was automatically updated to reflect the committed changes.