[Notifications KCM] Move Plasma Workspace "service" to the top of its category
ClosedPublic

Authored by broulik on Jan 4 2020, 10:53 PM.

Details

Summary

Makes it obvious that it's more of an overall category of general stuff, since this is where warning sounds, login/logout sounds, etc are located in.

Test Plan

Should it perhaps get an explanatory text? Something like "Configure general information and warning messages as well as startup and shutdown sounds."?

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 4 2020, 10:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2020, 10:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 4 2020, 10:53 PM

Hmm, it's a bit odd to have an item not in a section when everything else is. Maybe it could be moved to the top of the "System Services" category or be renamed "General" or something.

hmm, I wanted to have it more obvious than being the first "System Service"

broulik updated this revision to Diff 73419.Jan 13 2020, 3:21 PM
broulik retitled this revision from [Notifications KCM] Move Plasma Workspace "service" to the top to [Notifications KCM] Move Plasma Workspace "service" to the top of its category.
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
  • Sort it only to the top of services category
ngraham accepted this revision.Jan 13 2020, 3:42 PM
This revision is now accepted and ready to land.Jan 13 2020, 3:42 PM
This revision was automatically updated to reflect the committed changes.