The review gets submitted with your full name, but the review dialog currently shows
both the full name and username. This patch removes the username display so that it shows
the actual name string that will be used.
Details
Details
- Reviewers
apol - Group Reviewers
Discover Software Store - Commits
- R134:ec5464e70642: Only show full name in review dialog
Before:
After:
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@jgrulich you included that, right? Do you remember why? I can see it's used for generating the user hash.
Comment Actions
I don't really remember, but I can see in the userHash() it's not used so this is probably safe. In the userHash() we directly use KUser().