Differential D26421

Only show full name in review dialog
ClosedPublic
Actions

Authored by ngraham on Jan 4 2020, 9:39 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Commits
R134:ec5464e70642: Only show full name in review dialog
Summary

The review gets submitted with your full name, but the review dialog currently shows
both the full name and username. This patch removes the username display so that it shows
the actual name string that will be used.

Test Plan

Before:


After:

Diff Detail

Repository
R134 Discover Software Store
Branch
full-name-only (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20631
Build 20649: arc lint + arc unit
ngraham created this revision.Jan 4 2020, 9:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2020, 9:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 4 2020, 9:39 PM
apol added a subscriber: jgrulich.Jan 6 2020, 11:35 PM

@jgrulich you included that, right? Do you remember why? I can see it's used for generating the user hash.

jgrulich added a comment.Jan 7 2020, 12:46 PM

I don't really remember, but I can see in the userHash() it's not used so this is probably safe. In the userHash() we directly use KUser().

apol accepted this revision.Jan 14 2020, 9:57 PM
This revision is now accepted and ready to land.Jan 14 2020, 9:57 PM
Closed by commit R134:ec5464e70642: Only show full name in review dialog (authored by ngraham). · Explain WhyJan 14 2020, 11:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72767

View Options

libdiscover/appstream/OdrsReviewsBackend.cpp

Loading...