Differential D26405

Add mime type for backtraces saved from DrKonqi
ClosedPublic
Actions

Authored by broulik on Jan 3 2020, 9:56 PM.

Details

Reviewers
sitter
mpyne
Group Reviewers
Frameworks
Commits
R244:ae1fb551ce19: Add mime type for backtraces saved from DrKonqi
Test Plan

There's also text/x-apport

  • My saved crash reports can now have a nice icon

  • Normal text files are unchanged

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 3 2020, 9:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 3 2020, 9:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jan 3 2020, 9:56 PM
broulik edited the test plan for this revision. (Show Details)
sitter added a subscriber: mpyne.Jan 15 2020, 4:36 PM

+1 form me. not sure if @mpyne wants to have a look as well.

mpyne accepted this revision.Jan 15 2020, 10:01 PM

Thanks Harald. Patch looks good and I've checked that the file name pattern is what Dr. Konqi uses by default. One question though, @broulik you mentioned there's also text/x-apport, should that be changed here too or is this changeset just for *.kcrash.txt? If the apport mention is for something else then I'd say to go ahead and commit.

This revision is now accepted and ready to land.Jan 15 2020, 10:01 PM
broulik added a comment.Jan 16 2020, 9:30 AM

there's also text/x-apport

I just noticed that Breeze had an icon for that, I don't actually find it in mime info

Closed by commit R244:ae1fb551ce19: Add mime type for backtraces saved from DrKonqi (authored by broulik). · Explain WhyJan 16 2020, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mimetypes/kde5.xml (6 lines)

Diff 73684

View Options

src/mimetypes/kde5.xml

Loading...