Turn application/x-ms-shortcut into an actual shortcut icon
ClosedPublic
Actions

Authored by broulik on Jan 3 2020, 8:32 PM.

Details

Reviewers

ndavis

Group Reviewers

VDG

Commits

Summary

Rather than a banknote or money symbol. Git log suggests this was added for GNU cash, but .lnk files are windows shortcut files, effectively links.

Test Plan

Don't know what to do about icons-dark. Do the symbolic 16/22 mimetype icons colorize? are they always dark? always white?

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Jan 3 2020, 8:32 PM

For 16/22px, the current way is acceptable.

This patch does not apply cleanly. The base commit isn't available.

This revision now requires changes to proceed.Jan 5 2020, 6:32 AM

Make sure you copy to breeze dark as well

This revision is now accepted and ready to land.Jan 5 2020, 8:34 PM

This revision was automatically updated to reflect the committed changes.

		Path
M	M	icons-dark/mimetypes/16/application-x-ms-shortcut.svg (1 line)
M	M	icons-dark/mimetypes/22/application-x-ms-shortcut.svg (1 line)
M		icons-dark/mimetypes/32/application-x-ms-shortcut.svg (42 lines)
M		icons-dark/mimetypes/64/application-x-ms-shortcut.svg (48 lines)
M	M	icons/mimetypes/16/application-x-ms-shortcut.svg (1 line)
M	M	icons/mimetypes/22/application-x-ms-shortcut.svg (1 line)
M		icons/mimetypes/32/application-x-ms-shortcut.svg (206 lines)
M		icons/mimetypes/64/application-x-ms-shortcut.svg (209 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72712			Jan 3 2020, 8:28 PM	★	★
Diff 2	72817			Jan 5 2020, 5:39 PM	★	★
Diff 3	72834	4516200	R266:d5d0e2668d4bdc35dea9bcf194fb03017cb73445	Jan 5 2020, 8:59 PM	★	★