File indexing and Content file indexing benefits from immutability. But exclude/include list don't benefits from it because the UI represent both with the same list
Details
Details
- Reviewers
ervin crossi meven - Group Reviewers
Plasma - Commits
- R119:661b40c9ab0b: KCM Baloo: Migrate to KConfigXT and add immutability
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kcms/baloo/filteredfoldermodel.cpp | ||
|---|---|---|
| 6 | Missing the * and an empty line after that one. | |
| 61 | Indentation of that line and the previous one looks wrong... but surprisingly the previous line is not showing up as changed, I wonder if that's the review tool acting up. | |
| 161–163 | Could have been the first line of that method, would avoid retrieving that list twice and make the if condition more readable. | |
| kcms/baloo/filteredfoldermodel.h | ||
| 34–35 | Declare it as a slot for good measure (although it's technically not really necessary). | |
| kcms/baloo/kcm.cpp | ||
| 66 | Why not connect directly to updateDirectoryList in m_filteredFolderModel? Those lambdas look unnecessary (besides you'd want m_filteredFolderModel and not this as third parameter anyway). Also you probably want to call updateDirectoryList() once just after those connects. | |
| 78 | I don't think this call is necessary (it's probably because of the missing call in the ctor). | |
| 87 | Why are you updating m_previouslyEnabled again? The old code wasn't doing this AFAICT. | |
| 115 | Same thing, I don't think this is necessary. defaults() can likely completely go away. | |
| 128 | The opening curly brace should be on its own line. | |
| kcms/baloo/package/contents/ui/main.qml | ||
| 50 | nitpick: I'd put enabled before checked | |