DesktopPaths KCM: Remove the moving directory logic
ClosedPublic

Authored by ervin on Jan 3 2020, 11:55 AM.

Details

Summary

This simplifies greatly this otherwise mundane KCM. It introduced a lot
of complexity while gettings things wrong anyway: it would miss if a
directory is included in another one except in the "autostart inside
desktop" case, it would also leave you stranded in case of an
uncompleted move.

So now the KCM has a clear purpose: edit the settings. Moving data
around is still up to the user using a proper filemanager.

Long term it would probably be better for the filemanager to edit the
settings automatically when the user move on of those folders around,
then the KCM could be decommissioned.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Jan 3 2020, 11:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2020, 11:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin requested review of this revision.Jan 3 2020, 11:55 AM
davidedmundson accepted this revision.Jan 6 2020, 4:08 PM

it would also leave you stranded in case of an

uncompleted move.

That's actually quite easy to hit if a move causes conflcts and you press cancel...I just did so when testing to see if there were any other features we'd lose.

Given this codepath once caused widespread dataloss, I'm all for killing it.

This revision is now accepted and ready to land.Jan 6 2020, 4:08 PM
This revision was automatically updated to reflect the committed changes.