Differential D26388

Get rid of KGlobalSettings
ClosedPublic
Actions

Authored by ervin on Jan 3 2020, 11:54 AM.

Details

Reviewers
mart
davidedmundson
bport
crossi
meven
Group Reviewers
Plasma
Commits
R119:29c01adcc4a5: Get rid of KGlobalSettings
Summary

After grepping in all our repositories, it looks like the SETTINGS_PATHS
category is completely unused (at least I couldn't find anyone doing
anything paths related on the slot end).

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Jan 3 2020, 11:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2020, 11:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin requested review of this revision.Jan 3 2020, 11:54 AM
meven accepted this revision.Jan 3 2020, 12:02 PM

Looks fine to me

This revision is now accepted and ready to land.Jan 3 2020, 12:02 PM
davidedmundson accepted this revision.Jan 6 2020, 4:21 PM

Couldn't even find a reference in kde-workspace / kdelibs in plasma4 code when I went searching...

Closed by commit R119:29c01adcc4a5: Get rid of KGlobalSettings (authored by ervin). · Explain WhyJan 8 2020, 11:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73049

View Options

kcms/desktoppaths/CMakeLists.txt

Loading...
View Options

kcms/desktoppaths/globalpaths.cpp

Loading...