Details
- Reviewers
ngraham hein - Group Reviewers
Plasma - Commits
- R120:4dca72bdf59a: Kicker/RecentDocuments: add icons to actions
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I would have needed to edit Kicker::createActionItem, it might be interesting.
But not keeping the const is not too important those variables have a limited lifetime anyway.
Not having const here does not add a copy or anything.
I am not too fond of this version growing the number of parameters of Kicker::createActionItem, and given its third parameter before icon is QVariant this becomes error-prone.
There are a lot more usage of this method that I haven't yet updated, if we want to follow this course.
Yeah, it definitely bloats this diff, but maybe it would make subsequent ones smaller and cleaner?
Plasma folks, what do you think?
applets/kicker/plugin/contactentry.cpp | ||
---|---|---|
117 | I missing an icon for this action, I am open for suggestion. |
applets/kicker/plugin/contactentry.cpp | ||
---|---|---|
117 | Maybe user-identity or identity, depending on what it does |