Differential D2637

Make message switching in kmail much faster (also fixes a focus issue)
ClosedPublic
Actions

Authored by dfaure on Aug 31 2016, 6:09 PM.

Details

Reviewers
mlaurent
Commits
R94:4e32803d7d21: Make message switching in kmail much faster (also fixes a focus issue)
Summary

This call to load() triggers a lot of internal stuff in WebEngine,
including NavigateToEntry, creation (and soon afterwards, deletion) of
QtWebEngineCore::RenderWidgetHostViewQtDelegateWidget, etc.

I can't see any regression when removing this call.

On the contrary, this fixes a focus issue: when clicking on an
external link in an email and coming back to kmail, arrow up/down
didn't work anymore, because the last widget installed as focusproxy
for the webview (the DelegateWidget above) had been deleted meanwhile.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 6395.Aug 31 2016, 6:09 PM
dfaure retitled this revision from to Make message switching in kmail much faster (also fixes a focus issue).
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: mlaurent.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 31 2016, 6:09 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent accepted this revision.Sep 1 2016, 4:39 AM
mlaurent edited edge metadata.

It's an old code (see comment). So if it fixes your focus problem it's a good idea to remove it.
I tested it it seems ok for me too. No regression here.

Thanks
Regards

This revision is now accepted and ready to land.Sep 1 2016, 4:39 AM
Closed by commit R94:4e32803d7d21: Make message switching in kmail much faster (also fixes a focus issue) (authored by dfaure). · Explain WhySep 2 2016, 2:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6403

View Options

messageviewer/src/htmlwriter/webengineparthtmlwriter.cpp

Loading...