Differential D26367

Make the lookandfeel KCM build without XCursor support
ClosedPublic
Actions

Authored by ouwerkerk on Jan 2 2020, 2:32 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R119:1c43e1b4f7b1: Make the lookandfeel KCM build without XCursor support

Summary

With this change the lookandfeel KCM can be built without X11 cursor development headers.
In the case the KCM is built without XCursor support, it will not be able to reload the cursor dynamically at runtime but it will still be able to configure cursor themes.

This is an alternative to: D26344 (https://phabricator.kde.org/D26344)

Test Plan

plasma-desktop builds using kdesrc-build with and without X11 cursor development headers present.

Diff Detail

Repository

R119 Plasma Desktop

Branch

lookandfeel-without-cursors

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20536
Build 20554: arc lint + arc unit

ouwerkerk created this revision.Jan 2 2020, 2:32 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 2 2020, 2:32 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ouwerkerk requested review of this revision.Jan 2 2020, 2:32 PM

Harbormaster completed remote builds in B20536: Diff 72617.Jan 2 2020, 2:32 PM

ouwerkerk edited the summary of this revision. (Show Details)Jan 2 2020, 2:34 PM

ouwerkerk added a reviewer: Plasma.

davidedmundson accepted this revision.Jan 2 2020, 2:35 PM

This revision is now accepted and ready to land.Jan 2 2020, 2:35 PM

Closed by commit R119:1c43e1b4f7b1: Make the lookandfeel KCM build without XCursor support (authored by ouwerkerk). · Explain WhyJan 2 2020, 2:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcms/lookandfeel/CMakeLists.txt (30 lines)
M			kcms/lookandfeel/autotests/CMakeLists.txt (10 lines)
M			kcms/lookandfeel/config-kcm.h.cmake (3 lines)
M			kcms/lookandfeel/kcm.cpp (15 lines)