Differential D26352

Fully port away from KIconThemes
ClosedPublic
Actions

Authored by nicolasfella on Jan 1 2020, 7:28 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T11637: KIconThemes Cleanups

Commits

R351:0c8dcfff02e9: Fully port away from KIconThemes

Summary

Depends on D26350

Mostly just removing unused includes
In two places replace KIconLoade::SizeSmall with QStyle equivalent

Diff Detail

Repository

R351 KSystemLog

Branch

iconthemes

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20504
Build 20522: arc lint + arc unit

nicolasfella requested review of this revision.Jan 1 2020, 7:28 PM

nicolasfella created this revision.

Harbormaster completed remote builds in B20504: Diff 72570.Jan 1 2020, 7:28 PM

nicolasfella edited the summary of this revision. (Show Details)Jan 1 2020, 7:29 PM

nicolasfella added a dependency: D26350: Don't create pixmaps for loglevel icons.

nicolasfella added a reviewer: Plasma.Jan 1 2020, 7:33 PM

nicolasfella added a task: T11637: KIconThemes Cleanups.

+1 when teh decpendency is in.

davidedmundson accepted this revision.Apr 20 2020, 11:06 AM

This revision is now accepted and ready to land.Apr 20 2020, 11:06 AM

Closed by commit R351:0c8dcfff02e9: Fully port away from KIconThemes (authored by nicolasfella). · Explain WhyApr 20 2020, 8:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			src/configurationDialog.cpp (1 line)
M			src/detailDialog.cpp (1 line)
M			src/lib/CMakeLists.txt (1 line)
M			src/lib/loadingBar.cpp (1 line)
M			src/lib/logLevel.cpp (1 line)
M			src/lib/logMode.cpp (2 lines)
M			src/lib/logViewColumn.cpp (2 lines)
M			src/lib/logViewFilterWidget.cpp (3 lines)
M			src/lib/logViewSearchWidget.cpp (3 lines)
M			src/modes/base/fileListHelper.cpp (1 line)
M			src/modes/base/logLevelSelectionDialog.cpp (1 line)
M			src/tabLogViewsWidget.cpp (1 line)

Diff 72570

CMakeLists.txt

Loading...

src/configurationDialog.cpp

Loading...

src/detailDialog.cpp

Loading...

src/lib/CMakeLists.txt

Loading...

src/lib/loadingBar.cpp

Loading...

src/lib/logLevel.cpp

Loading...

src/lib/logMode.cpp

Loading...

src/lib/logViewColumn.cpp

Loading...

src/lib/logViewFilterWidget.cpp

Loading...

src/lib/logViewSearchWidget.cpp

Loading...

src/modes/base/fileListHelper.cpp

Loading...

src/modes/base/logLevelSelectionDialog.cpp

Loading...

src/tabLogViewsWidget.cpp

Loading...