Expose show-line-count in the ConfigInterface
ClosedPublic

Authored by mludwig on Dec 31 2019, 8:08 AM.

Details

Summary

The show-line-count property is added to the ConfigInterface.

As Kile doesn't use KatePart's status bar, it needs a way to query whether the line count should be shown or not, so that Kile can show the line count in its own status bar.

Diff Detail

Repository
R39 KTextEditor
Lint
Lint Skipped
Unit
Unit Tests Skipped
mludwig created this revision.Dec 31 2019, 8:08 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 31 2019, 8:08 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
mludwig requested review of this revision.Dec 31 2019, 8:08 AM
cullmann requested changes to this revision.Dec 31 2019, 12:48 PM
cullmann added a subscriber: cullmann.

I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.
You missed to add the line-count to KTextEditor::ViewPrivate::configKeys()

This revision now requires changes to proceed.Dec 31 2019, 12:48 PM
mludwig updated this revision to Diff 72484.Dec 31 2019, 1:50 PM

Add "line-count" to KTextEditor::ViewPrivate::configKeys()

I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.
You missed to add the line-count to KTextEditor::ViewPrivate::configKeys()

Good catch :) I've added it now.

dhaumann accepted this revision.Jan 1 2020, 12:38 AM
dhaumann added a subscriber: dhaumann.

Ok with this... Thanks. A note " Since 5.6x would be nice".

This revision was not accepted when it landed; it landed in state Needs Review.Jan 1 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.