Differential D26308

Set output device's logical size
Needs ReviewPublic
Actions

Authored by romangg on Dec 30 2019, 10:48 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Maniphest Tasks

T11222: Reimagine output cloning

Summary

This adds protocol methods and API to query and set explicitly the logical size
of an output where the logical size is defined as the internal representation
of this output in the compositor space.

Test Plan

Tested with output replications through KScreen.

Diff Detail

Repository

R127 KWayland

Branch

replicaSize

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 20426
Build 20444: arc lint + arc unit

romangg created this revision.Dec 30 2019, 10:48 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 30 2019, 10:48 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

romangg requested review of this revision.Dec 30 2019, 10:48 PM

Harbormaster completed remote builds in B20426: Diff 72427.Dec 30 2019, 10:48 PM

This is an alternative to D23619 with more patches to come as discussed with David back then.

src/client/outputdevice.h
98	rm
src/client/protocols/outputdevice.xml
293	fix summary
296	spelling
src/server/outputdevice_interface.h
86	rm

I thought about adding separate events/requests for an immutable`logical_size` just giving always back the current logical size of the output and logical_size_override always giving back the explicitly set logical size or an invalid size if none is set.

romangg added a dependent revision: D26309: feat: replace replication source with logical size API.Dec 30 2019, 11:00 PM

romangg added a dependent revision: D26311: Handle output logical size changes.Dec 30 2019, 11:14 PM

Add autotest
Cleanup

Harbormaster completed remote builds in B20534: Diff 72615.Jan 2 2020, 2:06 PM

romangg removed a dependent revision: D26309: feat: replace replication source with logical size API.Jan 6 2020, 9:29 PM

romangg added a task: T11222: Reimagine output cloning.Jan 9 2020, 12:36 PM

Revision Contents
Changeset List

			Path	Packages
M			src/client/outputconfiguration.h (12 lines)
M			src/client/outputconfiguration.cpp (8 lines)
M			src/client/outputdevice.h (7 lines)
M			src/client/outputdevice.cpp (25 lines)
M			src/client/protocols/output-management.xml (24 lines)
M			src/client/protocols/outputdevice.xml (13 lines)
M			src/client/registry.cpp (4 lines)
M			src/server/outputchangeset.h (9 lines)
M			src/server/outputchangeset.cpp (13 lines)
M			src/server/outputchangeset_p.h (1 line)
M			src/server/outputconfiguration_interface.cpp (21 lines)
M			src/server/outputdevice_interface.h (25 lines)
M			src/server/outputdevice_interface.cpp (42 lines)
M			src/server/outputmanagement_interface.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	72427	123ebd5		Dec 30 2019, 10:48 PM	★	★
Diff 2	72615	123ebd5	- Add autotest	Jan 2 2020, 2:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2e2589d696d0	a4a48023f1da	c76edbdcf65d	Roman Gilg	Fractional logical size	Dec 30 2019, 10:40 PM
c76edbdcf65d	7669024ac1b7	a1136525f086	Roman Gilg	Remove size hint again	Oct 28 2019, 1:51 PM
a1136525f086	4d0a190e298f	123ebd5b3dc8	Roman Gilg	Set logical size with size hint	Oct 27 2019, 2:22 PM