Fix Ctrl+F shortcut conflict
ClosedPublic

Authored by ngraham on Dec 30 2019, 9:24 PM.

Details

Summary

The base app was always setting Ctrl+F as a search shortcut, even when the toolbar upon
which the search field lives was not visible. This caused the dreaded "ambiguous shortcut"
dialog to appear. The patch fixes the issue by setting the shortcut only when the toolbar
contains a search field, and unsetting it when the toolbar is hidden.

BUG: 405030
FIXED-IN: 5.18

Test Plan

Hit Ctrl+F in both sidebar and icons view. In both cases, it focuses the search
field.

Diff Detail

Repository
R124 System Settings
Branch
fix-shortcut-conflict (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20423
Build 20441: arc lint + arc unit
ngraham created this revision.Dec 30 2019, 9:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 9:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 30 2019, 9:24 PM
ngraham added inline comments.
app/SettingsBase.cpp
422

Dunno why phab is showing this; I didn't actually remove the trailing newline.

apol added a subscriber: apol.Dec 31 2019, 6:44 PM

Patch looks good.

app/SettingsBase.cpp
422

kate and vim do in some occasions.

ngraham updated this revision to Diff 72503.Dec 31 2019, 8:05 PM
ngraham marked 2 inline comments as done.

Fix whitespace

ngraham edited the summary of this revision. (Show Details)Dec 31 2019, 8:06 PM
apol accepted this revision.Jan 4 2020, 5:22 PM
This revision is now accepted and ready to land.Jan 4 2020, 5:22 PM
This revision was automatically updated to reflect the committed changes.