[Notifications] Don't show DrKonqi notifications in history
ClosedPublic

Authored by broulik on Dec 30 2019, 5:25 PM.

Details

Summary

It creates a tray icon, so having a history entry is just annoying duplication.

Test Plan

5.17?

  • Ran kate, kill -6 `pidof kate, got a drkonqi tray icon and notification, let notification expire, it didn't end up in history

DrKonqi's tray icon is smart enough already to stay there for max 1 minute unless the computer is idle, so that when a process dies in the middle of the night, you'll see it next time you come around, whicih is imho perfect and does't need any form of history.

You can't change this behavior in the UI as DrKonqi's desktop entry is NoDisplay and we don't have per-event history config yet

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 30 2019, 5:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 5:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 30 2019, 5:25 PM
ngraham accepted this revision.Dec 30 2019, 6:11 PM
ngraham added a subscriber: ngraham.

Stable branch makes sense to me.

This revision is now accepted and ready to land.Dec 30 2019, 6:11 PM
This revision was automatically updated to reflect the committed changes.