Details
Details
- Reviewers
ervin - Group Reviewers
Plasma - Commits
- R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20409 Build 20427: arc lint + arc unit
Comment Actions
Just a nitpick you can feel free to ignore, otherwise LGTM.
kcms/dateandtime/dtime.cpp | ||
---|---|---|
166 | I'd use the opportunity to split that into two statements, I find the assign + test in if rather heavy to read. |
kcms/dateandtime/dtime.cpp | ||
---|---|---|
164 | nitpick again, feel free to fix or not before pushing: ntpUtility could be declared const |