Differential D26295

[KCM/Datetime] Convert a foreach, port away from KStandardDirs
ClosedPublic
Actions

Authored by meven on Dec 30 2019, 4:27 PM.

Details

Reviewers
ervin
Group Reviewers
Plasma
Commits
R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20409
Build 20427: arc lint + arc unit
meven created this revision.Dec 30 2019, 4:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 4:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 30 2019, 4:27 PM
meven updated this revision to Diff 72396.Dec 30 2019, 4:39 PM

Add a KStandardDirs conversion

ervin accepted this revision.Dec 30 2019, 5:00 PM

Just a nitpick you can feel free to ignore, otherwise LGTM.

kcms/dateandtime/dtime.cpp
166

I'd use the opportunity to split that into two statements, I find the assign + test in if rather heavy to read.

This revision is now accepted and ready to land.Dec 30 2019, 5:00 PM
meven updated this revision to Diff 72453.Dec 31 2019, 8:38 AM

make a if conv clearer, convert code to use QStringList more

meven updated this revision to Diff 72454.Dec 31 2019, 8:39 AM
meven marked an inline comment as done.

fix indentation

meven updated this revision to Diff 72455.Dec 31 2019, 8:39 AM

fix indentation

ervin accepted this revision.Dec 31 2019, 8:58 AM
ervin added inline comments.
kcms/dateandtime/dtime.cpp
164

nitpick again, feel free to fix or not before pushing: ntpUtility could be declared const

Closed by commit R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs (authored by meven). · Explain WhyDec 31 2019, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/dateandtime/dtime.cpp (9 lines)

Diff 72394

View Options

kcms/dateandtime/dtime.cpp

Loading...