[KCM/Activity] Make default button work, modernize code
ClosedPublic

Authored by meven on Dec 30 2019, 12:36 PM.

Details

Test Plan

kcmshell5 activities
Default button states follows those of the privacy and switching tabs

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Dec 30 2019, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2019, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 30 2019, 12:36 PM
ervin requested changes to this revision.Dec 30 2019, 4:55 PM
ervin added inline comments.
kcms/activities/MainConfigurationWidget.cpp
59

Opening curly brace should be on its own line here

63

Ditto

kcms/activities/PrivacyTab.cpp
134

Ditto

kcms/activities/SwitchingTab.cpp
90

{ should be on its own line

This revision now requires changes to proceed.Dec 30 2019, 4:55 PM
meven edited the test plan for this revision. (Show Details)Dec 30 2019, 4:56 PM
meven updated this revision to Diff 72399.Dec 30 2019, 5:10 PM
meven marked 4 inline comments as done.

4 newlines were missing

ervin accepted this revision.Dec 31 2019, 8:04 AM
This revision is now accepted and ready to land.Dec 31 2019, 8:04 AM
This revision was automatically updated to reflect the committed changes.