Differential D26283

Set Qt::KeypadModifier depending on current keysym
ClosedPublic
Actions

Authored by romangg on Dec 30 2019, 3:04 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:514a95f1e43c: Set Qt::KeypadModifier depending on current keysym
Summary

The Qt::KeypadModifier should only accompany a keysym when this specific keysym
originates from the keypad not in general for every keysym while numlock is
engaged.

BUG: 400658
FIXED-IN: 5.18.0

Test Plan

Manually with the Thumbnail Grid task switcher and numlock enabled.

Diff Detail

Repository
R108 KWin
Branch
numlock-tabbox-fix
Lint
Lint ErrorsExcuse: other code
SeverityLocationCodeMessage
Errorinput.h:310CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 20388
Build 20406: arc lint + arc unit
romangg created this revision.Dec 30 2019, 3:04 AM
Restricted Application added a project: KWin. · View Herald TranscriptDec 30 2019, 3:04 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Dec 30 2019, 3:04 AM
romangg edited the summary of this revision. (Show Details)Dec 30 2019, 3:06 AM
davidedmundson accepted this revision.Dec 30 2019, 7:11 AM
This revision is now accepted and ready to land.Dec 30 2019, 7:11 AM
romangg edited the summary of this revision. (Show Details)Dec 30 2019, 1:19 PM
Closed by commit R108:514a95f1e43c: Set Qt::KeypadModifier depending on current keysym (authored by romangg). · Explain WhyDec 30 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxkb.cpp (2 lines)
Mxkb_qt_mapping.h (9 lines)

Diff 72358

View Options

xkb.cpp

Loading...
View Options

xkb_qt_mapping.h

Loading...