Differential D26269

Remove deprecated mostLocalUrl
ClosedPublic
Actions

Authored by gengisdave on Dec 29 2019, 8:57 AM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Commits
R167:528c1977e27f: Replace obsolete KFileItem::mostLocalUrl(bool &)
Summary

In the latest KIO, KFileItem::mostLocalUrl(bool &) was deprecated in favor of KFileItem::mostLocalUrl(bool *). This new method exists since 5.0, no version checks are needed

Test Plan

The method is used only in KrFileTreeView::copyToClipBoard, when the Sidebar is active in Tree Panel mode, the popup commands Cut and Copy should work.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gengisdave requested review of this revision.Dec 29 2019, 8:57 AM
gengisdave created this revision.
asensi accepted this revision as: asensi.Jan 15 2020, 11:08 PM
asensi added a subscriber: asensi.

The improvements worked under Kubuntu 18.04 LTS and Kubuntu 19.10, other people can do their checks. Thanks, Davide!

This revision is now accepted and ready to land.Jan 15 2020, 11:08 PM
Closed by commit R167:528c1977e27f: Replace obsolete KFileItem::mostLocalUrl(bool &) (authored by gengisdave). · Explain WhyFeb 10 2020, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkrusader/Panel/krfiletreeview.cpp (2 lines)

Diff 75338

View Options

krusader/Panel/krfiletreeview.cpp

Loading...