Differential D26260

drawletters mistakes corrected
ClosedPublic
Actions

Authored by dekumar on Dec 28 2019, 6:45 PM.

Details

Reviewers
echarruau
jjazeix
Group Reviewers
GCompris: Bugs
Maniphest Tasks
T12438: Drawletters: correct incorrect letter drawings
Summary

I have fixed the behaviour of all the letters as described in the ticket https://phabricator.kde.org/T12438

Diff Detail

Repository
R2 GCompris
Branch
drawletter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20350
Build 20368: arc lint + arc unit
dekumar created this revision.Dec 28 2019, 6:45 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 28 2019, 6:45 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
dekumar requested review of this revision.Dec 28 2019, 6:45 PM
dekumar retitled this revision from letters mistakes fixed to drawletters mistakes corrected.Dec 28 2019, 6:48 PM
dekumar edited the summary of this revision. (Show Details)
dekumar added reviewers: GCompris: Bugs, echarruau.
dekumar added a task: T12438: Drawletters: correct incorrect letter drawings.
jjazeix accepted this revision.Jan 4 2020, 1:39 PM
jjazeix added a subscriber: jjazeix.

Thank you.
I also fixed the G that was missing and added back a point in the O you forgot.
Commited in https://commits.kde.org/gcompris/b0f79bdc62a337793a76d41237ca1ac71ee0ca03

This revision is now accepted and ready to land.Jan 4 2020, 1:39 PM
jjazeix closed this revision.Jan 4 2020, 1:39 PM

Revision Contents
Changeset List

Diff 72304

View Options

src/activities/drawletters/drawletters_dataset.js

Loading...