Differential D26257

Add extractors for Kintetsu Railway Limited Express reservations
ClosedPublic
Actions

Authored by lbeltrame on Dec 28 2019, 3:13 PM.

Details

Reviewers
vkrause
Commits
R1003:8fe0e4298e4d: Add extractors for Kintetsu Railway Limited Express reservations
Summary

The format is free-form text, so regular expressions are necessary.
Everything but the train name/number (which is not in the email sent by
their system) is extracted.

Test Plan

Manually fed an email in kitinerary-workbench, got data extracted.

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lbeltrame created this revision.Dec 28 2019, 3:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 28 2019, 3:13 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
lbeltrame requested review of this revision.Dec 28 2019, 3:13 PM
lbeltrame added a comment.Dec 28 2019, 3:15 PM

@vkrause I can provide you some anonymized data for your tests if need be.

vkrause accepted this revision.Dec 28 2019, 3:24 PM

Thanks! Test data is always a good idea to prevent this breaking on engine changes. For plain text it might even be possible to create a synthetic one to add to the extractor tests in this repo, but that's not a blocker.

src/extractors/kintetsu.js
35

Those two lines should not be needed.

This revision is now accepted and ready to land.Dec 28 2019, 3:24 PM
lbeltrame updated this revision to Diff 72300.Dec 28 2019, 3:36 PM
  • Merge branch 'master' into kintetsu-extractor
Closed by commit R1003:8fe0e4298e4d: Add extractors for Kintetsu Railway Limited Express reservations (authored by lbeltrame). · Explain WhyDec 28 2019, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMsrc/extractors/kintetsu.js (63 lines)
AMsrc/extractors/kintetsu.json (13 lines)

Diff 72301

View Options

src/extractors/kintetsu.js

Loading...
View Options

src/extractors/kintetsu.json

Loading...