Differential D26246

use QLoggingCategory for logging
ClosedPublic
Actions

Authored by abondarenko on Dec 27 2019, 6:33 PM.

Details

Reviewers
mlaurent
Commits
R180:c255a9adba44: use QLoggingCategory for logging
Summary

Logging with QLoggingCategory instead of QtGlobal functions (qDebug, qInfo, etc)
allow users to filter out unwanted messages with kdebugsettings and qtlogging.ini

Diff Detail

Repository
R180 PIM: KMime
Lint
Lint Skipped
Unit
Unit Tests Skipped
abondarenko created this revision.Dec 27 2019, 6:33 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 27 2019, 6:33 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
abondarenko requested review of this revision.Dec 27 2019, 6:33 PM
mlaurent requested changes to this revision.Dec 27 2019, 7:45 PM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/CMakeLists.txt
31

Why warning by default ?

if you add it you need to adapt kmime.categories for defining it (DEFAULT_SEVERITY [WARNING])

This revision now requires changes to proceed.Dec 27 2019, 7:45 PM
abondarenko updated this revision to Diff 72284.Dec 28 2019, 8:27 AM

There is no reason for setting default logging level to Warning. Reset to default.

abondarenko marked an inline comment as done.Dec 28 2019, 8:29 AM

Removed DEVAULT_SEVERITY from CMakeLists.txt

mlaurent requested changes to this revision.Dec 28 2019, 2:57 PM
mlaurent added inline comments.
src/kmime_mdn.cpp
41 ↗(On Diff #72284)

Please remove QDebug as it's already define in kmime_debug.h

same for others files.

Thanks

This revision now requires changes to proceed.Dec 28 2019, 2:57 PM
abondarenko updated this revision to Diff 72303.Dec 28 2019, 6:23 PM

Remove unused QDebug includes

abondarenko marked an inline comment as done.Dec 28 2019, 6:32 PM

I've removed unused QDebug except one in kmime_codecs.cpp. I don't have enough knowledge for it. When I'm trying to use KMIME_LOG in kmime_codecs.cpp, I get compile error in autotests.

mlaurent accepted this revision.Dec 29 2019, 8:40 AM

"I've removed unused QDebug except one in kmime_codecs.cpp. I don't have enough knowledge for it. When I'm trying to use KMIME_LOG in kmime_codecs.cpp, I get compile error in autotests." I will look at it after your commit.+

Thanks for doing it.

Do you have a commit access or you want that we commit for you ?

This revision is now accepted and ready to land.Dec 29 2019, 8:40 AM
abondarenko added a comment.Dec 29 2019, 9:16 AM

No. I don't have commit access. Please commit it for me.

Closed by commit R180:c255a9adba44: use QLoggingCategory for logging (authored by mlaurent). · Explain WhyDec 29 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (6 lines)
Msrc/kmime_content.cpp (1 line)
Msrc/kmime_mdn.cpp (4 lines)
Msrc/kmime_types.cpp (4 lines)
Msrc/kmime_util.cpp (10 lines)

Diff 72303

View Options

src/CMakeLists.txt

Loading...
View Options

src/kmime_content.cpp

Loading...
View Options

src/kmime_mdn.cpp

Loading...
View Options

src/kmime_types.cpp

Loading...
View Options

src/kmime_util.cpp

Loading...