This patch reduces the amount of duplicate code and makes every part of the helper functions use the correct frame radius.
Details
Details
- Reviewers
hpereiradacosta ngraham - Group Reviewers
Breeze Plasma - Commits
- R31:5bd591bb0f3b: Change frameRadius to use pen widths, add frameRadiusForNewPenWidth, add…
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Branch
- replace-hardcoded-2 (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 20386 Build 20404: arc lint + arc unit
kstyle/breezehelper.h | ||
---|---|---|
318 | Would need a new function name than "newFrameRadius", that makes it clear when this should be used on not the other. |
Comment Actions
- Change newFrameRadius to newPenWidthFrameRadius
This name doesn't sound very good, but at least it's more descriptive.
Comment Actions
- Change newPenWidthFrameRadius to frameRadiusNewPenWidth
This sounds slightly better to me and allows it to show up next to frameRadius when autocompleting.
Comment Actions
What about "frameRadiusForPenWidth" ?
I think the "New" is misleading.
If you agree, please change and then commit. The rest sounds good.
Comment Actions
- use frameRadiusForNewPenWidth
I think the use of the word new is important here because it's for taking an existing radius and modifying it based on a new pen width. frameRadiusForPenWidth sounds like it works the same as frameRadius.