The replaced numbers are directly related to the width of the pen.
This patch likely doesn't replace all of the numbers that could be replaced.
It just replaces the ones I'm currently certain of being related to pen width.
The goal is to make the code show the intent of the designer.
Details
- Reviewers
hpereiradacosta ngraham - Group Reviewers
Breeze Plasma - Commits
- R31:c16eb7a4614f: Add standard pen widths and replace hardcoded numbers
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
+1, seems sensible to me, but probably wait for @hpereiradacosta's go-ahead.
kstyle/breeze.h | ||
---|---|---|
179 | Why three slashes for these comments? |
kstyle/breeze.h | ||
---|---|---|
179 | It's a Doxygen style. If you do it, KDevelop shows the comments in the tooltips for the commented functions, classes and variables. |
kstyle/breeze.h | ||
---|---|---|
179 | Probably makes sense to do this universally all at once, rather than in little bits and pieces. |
...And after these patches land, let's do the doxygen-friendly comment formatting all at once in another patch.
looks good. See comment about the symbol pen width change and then ship it.
Most comments should already be doxygen friendly in breeze, except that * and /** are used instead of /
kstyle/breeze.h | ||
---|---|---|
180 | For the record, * (and /**) should also be caught by Doxygen (and hopefully KDevelop). It is used more or less systematically in oxygen, so please use this instead of / | |
kstyle/breezehelper.cpp | ||
1355 | Here the penwidth is actually changed (from 1.1 to 1.01) this could affect the appearance of the actual buttons. Are you happy with the new appearance ? In fact for the sake of changing only one thing at a time, I would set penwidth::Symbol to 1.1 |
kstyle/breeze.h | ||
---|---|---|
180 | OK. KDevelop won't always detect comments that use other doxygen styles or display them correctly, but that's a KDevelop problem, not a Breeze code problem. | |
kstyle/breezehelper.cpp | ||
1355 | Yes, 1.01 works fine. 1.1 is slightly visible when scaling up the UI, so I changed it. I had planned to do the KDecoration after this patch. I will put the width change in a different commit though. |