Fix localization of the systemmonitor widget configuration window
ClosedPublic

Authored by yurchor on Dec 23 2019, 5:14 PM.

Details

Summary

Currently, the common config window messages are neither extracted nor used in all 5 widgets. It is not possible to add several translation catalogs for a single QML widget thus the messages are extracted into all 5 widget catalogs.

Idea of the fix by Victor Ryzhykh.

Test Plan

Extraction tested to work as expected, translation should work too.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Dec 23 2019, 5:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 23 2019, 5:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yurchor requested review of this revision.Dec 23 2019, 5:14 PM
davidedmundson accepted this revision.Dec 23 2019, 5:19 PM
This revision is now accepted and ready to land.Dec 23 2019, 5:19 PM
ngraham accepted this revision.Dec 23 2019, 7:10 PM
This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Dec 24 2019, 11:10 AM

For the future, ideally, if a component is used as a library (like it seems is the case here) it should be extracted to it's own catalog and then translated with i18nd* variants that specify that catalog to be loaded instead of asking the translators to translate it N times (not that it's a problem since any good tool will make this very fast, but it's the better architectural solution in my opinion)