[KCM/Component] Clean deprecated code, modernize code
ClosedPublic

Authored by meven on Dec 23 2019, 11:14 AM.

Details

Test Plan

No changes

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Dec 23 2019, 11:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 23 2019, 11:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 23 2019, 11:14 AM
ervin requested changes to this revision.Dec 23 2019, 1:11 PM
ervin added inline comments.
kcms/componentchooser/componentchooser.cpp
83–86

Indentation looks wrong

125–134

Indentation looks wrong

127

Space before & not after

129

Space before & not after

This revision now requires changes to proceed.Dec 23 2019, 1:11 PM
meven updated this revision to Diff 72096.Dec 23 2019, 3:51 PM

Fix indentation (file mostly uses Tabs but not only), fix & position

meven updated this revision to Diff 72097.Dec 23 2019, 3:53 PM
meven marked 3 inline comments as done.

Fix & position

ervin accepted this revision.Dec 23 2019, 4:30 PM
This revision is now accepted and ready to land.Dec 23 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.