| sitter |
| Restricted Owners Package | (Owns No Changed Paths) |
Phonon 4.11.x doesn't build against Qt 5.9 because of a single env.var-related function call that must have been introduced in a later Qt version.
I don't see any mininmum Qt version specification, so here's a patch that makes the code build against at least Qt 5.9.8 .
Building against Qt 5.9.8
| Lint Skipped |
| Unit Tests Skipped |
| Buildable 20192 | |
| Build 20210: arc lint + arc unit |
But why, there's nothing that requires this other than that single env. var. function that may not even be the most appropriate one (I find the documentation a bit confusing).
Don't forget that Phonon is not Linux-specific and that on other platforms newer Qt versions no longer support older OS versions that are still being used. That includes the Mac OS version I'm on, so no, I won't condone taking that path.
KF5's Qt support strategy is sound and so phonon should follow that. We've moved away from keeping phonon backwards compatible to the big bang, it's not sustainable.
KF5's Qt support strategy is sound
Except that that too only requires overly new Qt versions for newfangled form-over-function stuff in frameworks like Kirigami, the rest would build against Qt 5.9 until at least 5.60.0 with minimal tweaking and zero feature loss.
And no framework serves as crucial a feature as Phonon does.
We've moved away from keeping phonon backwards compatible to the big bang, it's not sustainable.
Not what I am suggesting, but that's not the same as willingly dropping backwards compatibility just because you can. When was the big bang anyway, Qt v2? O:-) Certainly not Qt 5.9, which is officially still supported.