i18n: Split translations for strings "Translation"
ClosedPublic

Authored by aspotashev on Dec 22 2019, 11:09 PM.

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Dec 22 2019, 11:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 22 2019, 11:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aspotashev requested review of this revision.Dec 22 2019, 11:09 PM
kossebau accepted this revision.Dec 22 2019, 11:25 PM

Looks good to me for what I know as programmer, but none-translator :)
While at it, for consistency the other tab titles could also get a "@title:tab" UI marker context?

In general I am surprised how little usage of the UI markers are made in general. At the time when I wrote the main code of Okteta, it seemed good practice to add them everywhere, and so I did. Working on other KDE projects since I am confused why no-one else seems to use it... so a bit unsure when to use and when not.

This revision is now accepted and ready to land.Dec 22 2019, 11:25 PM

Looks good to me for what I know as programmer, but none-translator :)
While at it, for consistency the other tab titles could also get a "@title:tab" UI marker context?

While at it, yes

https://phabricator.kde.org/D26170

will try to push around January 5, 2020 after string freeze

Seems you went fully "at it", good work :)

"after string freeze" meant "after relase tagging for string freeze reasons" , right? ;)

Seems you went fully "at it", good work :)

"after string freeze" meant "after relase tagging for string freeze reasons" , right? ;)

Yes, of course.

This revision was automatically updated to reflect the committed changes.