[Notifications KCM] Force re-evaluation of position radio buttons
ClosedPublic

Authored by broulik on Dec 22 2019, 8:00 PM.

Details

Summary

The Settings object is kind of a write-only state and doesn't signal property changes unless "live" (where it would listen to other settings changing which we don't want inside the KCM) or only upon save().
This is arguably a questionable design decision on my side :-) but usually it's not a problem as the KCM controls will have whatever state the user will put them in but it falls apart in case we switch to another page and back without saving. This hack is good enough for stable branch anyway imho.

BUG: 414098
FIXED-IN: 5.17.5

Test Plan
  • Went to position selector, chose a position, went back. Radio button moved to the bottom position. Before that it would only do it when I hit save

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 22 2019, 8:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 22 2019, 8:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 22 2019, 8:00 PM
davidedmundson accepted this revision.Jan 15 2020, 9:11 AM
This revision is now accepted and ready to land.Jan 15 2020, 9:11 AM
This revision was automatically updated to reflect the committed changes.