Drop KWindowSystem dependency
ClosedPublic

Authored by davidedmundson on Dec 22 2019, 7:08 PM.

Details

Summary

KWindowSystem activateWindow does the same thing as the QPA does when
calling QWindow::requestActivate.

We can save a dependency.

Test Plan

Windows:
Read code for windows QPA + kwindowsystem and it seemed like the
same underlying call

X11:
Ran ./ktextedittest. pressed control+f. Window had focus

Wayland:
Both calls will no-op. It needs new API, but when that does exist
I'll make sure it's in QWayland.

Diff Detail

Repository
R310 KTextWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 22 2019, 7:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 22 2019, 7:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 22 2019, 7:08 PM
apol accepted this revision.Dec 23 2019, 2:21 AM
This revision is now accepted and ready to land.Dec 23 2019, 2:21 AM
This revision was automatically updated to reflect the committed changes.

Please also remove from kde-build-metadata

dfaure added a subscriber: dfaure.Jan 11 2020, 9:28 AM

Why isn't KWindowSystem::activateWindow deprecated then? Because of the time argument?

There's a big difference between "I want to raise my window" and I "I want to raise $random window".

We don't need to use this kwindowsystem api for the former, but kwin and plasma's task manager still need to use the latter.