Differential D26152

Made AdvanceTimer as Core file.
ClosedPublic
Actions

Authored by shubhammishra on Dec 22 2019, 10:31 AM.

Details

Reviewers
amankumargupta
echarruau
jjazeix
Group Reviewers
GCompris
Maniphest Tasks
T10315: Make AdvancedTimer in note_names a core element

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
shubhammishra added a comment.Dec 22 2019, 11:05 AM

removed 'import "note_names.js" as Activity' as i didn't find it's importance even after checking thoroughly.

jjazeix accepted this revision.EditedDec 22 2019, 11:38 AM
jjazeix added a subscriber: jjazeix.

Thank you!
QtQuick.Controls also is not used, I also removed it.
Committed in https://cgit.kde.org/gcompris.git/commit/?id=a106f3bf1766a973df05a17d7c71708db4c5d7a6

This revision is now accepted and ready to land.Dec 22 2019, 11:38 AM
jjazeix closed this revision.Dec 22 2019, 11:38 AM

Revision Contents
Changeset List

Diff 71985

View Options

src/activities/note_names/AdvancedTimer.qml

Loading...
View Options

src/core/AdvancedTimer.qml

Loading...